feat: remove Cal.ai tab from navigation while preserving URL access #23894

PeerRich · 2025-09-17T11:31:43Z

What does this PR do?

This PR implements two related changes to the Cal.ai integration in event types:

Adds Cal.ai Banner to Workflows Tab: Displays the same "Supercharge your Workflows with Cal.ai" banner that appears on /event-types to the workflows tab page (/event-types/{id}?tabName=workflows)
Removes Cal.ai Tab from Navigation: Completely removes the Cal.ai tab from the event types navigation while preserving URL access for backward compatibility

Link to Devin run: https://app.devin.ai/sessions/34ef1c121af3471bbe83b120b02327fe
Requested by: @PeerRich

Key Changes

Banner Addition (`EventWorkflowsTab.tsx`)

Imported CalAiBanner component from @calcom/features/shell/CalAiBanner
Added <CalAiBanner /> component after the LicenseRequired wrapper
The banner uses existing pathname-based visibility logic to show on workflows pages

Tab Removal (`useTabsNavigations.tsx`)

Removed the entire conditional block that added the Cal.ai tab to navigation
Extracted eventTypeId variable to avoid repeated formMethods.getValues("id") calls
Fixed ESLint warnings by adding missing dependencies to useMemo array

⚠️ Important Review Areas

Critical items to verify:

Banner visibility: Confirm CalAiBanner actually appears on workflows tab page - the visibility logic depends on pathname checking
Backward compatibility: Test that /event-types/{id}?tabName=ai URL still works for existing bookmarks/links, even though tab is removed from navigation
Banner positioning: Verify banner appears in correct location and doesn't break layout
ESLint dependency changes: The useMemo dependency fixes could affect re-rendering behavior

Testing limitation: ⚠️ Local testing was limited due to authentication issues, so visual functionality wasn't fully verified.

How should this be tested?

Banner functionality:
- Navigate to /event-types/{id}?tabName=workflows
- Verify Cal.ai banner appears at the top of the workflows tab
- Test banner dismiss functionality
Navigation changes:
- Confirm Cal.ai tab no longer appears in event type navigation
- Test that /event-types/{id}?tabName=ai URL still works directly (backward compatibility)
Layout verification:
- Check that banner positioning doesn't interfere with workflows content
- Verify responsive behavior on mobile

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

devin-ai-integration · 2025-09-17T11:31:46Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR that start with 'DevinAI'.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

coderabbitai · 2025-09-17T11:31:51Z

Walkthrough

Refactors tab navigation logic to derive a local eventTypeId from formMethods.getValues("id") and use it consistently for building navigation data and hrefs. Updates getNavigation and tab hrefs (recurring, availability, team, webhooks) to use eventTypeId. Removes the previously hidden "Cal.ai" tab and its associated navigation push logic. Expands dependencies for useMemo and effects to include eventTypeId, eventType.id, and formMethods, ensuring recomputation when the event type id changes. No exported/public API changes.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title accurately describes the removal of the Cal.ai tab and the preservation of direct URL access, which reflects a significant aspect of the implemented changes; it is clear, specific, and directly tied to the PR’s functionality even though it does not mention the added banner feature.
Description Check	✅ Passed	The description clearly outlines both the addition of the Cal.ai banner to the workflows tab and the removal of the Cal.ai tab with preserved URL compatibility, provides testing steps, and highlights key review areas, demonstrating direct relevance to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch devin/remove-cal-ai-tab-1758108209

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

vercel · 2025-09-17T11:36:52Z

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments

Project	Deployment	Preview	Comments	Updated (UTC)
cal	Ignored			Oct 7, 2025 6:36pm
cal-eu	Ignored			Oct 7, 2025 6:36pm

github-actions · 2025-10-02T00:22:23Z

This PR is being marked as stale due to inactivity.

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

packages/platform/atoms/event-types/hooks/useTabsNavigations.tsx (1)
133-133: Fix inconsistent ID reference in instant tab href.

All other tab hrefs use eventTypeId (derived from formMethods.getValues("id")), but the instant tab uses eventType.id from props. This inconsistency could cause mismatched URLs if the prop and form values diverge.

Apply this diff to use eventTypeId consistently:
-          href: `/event-types/${eventType.id}?tabName=instant`,
+          href: `/event-types/${eventTypeId}?tabName=instant`,

🧹 Nitpick comments (1)

packages/platform/atoms/event-types/hooks/useTabsNavigations.tsx (1)
74-75: Consider extracting eventTypeId inside the useMemo for cleaner reactivity.

Extracting eventTypeId at the component level works but creates an inefficient update pattern: when formMethods changes, the component re-renders, eventTypeId recalculates, then useMemo re-runs because both formMethods and eventTypeId changed. A cleaner pattern would be to derive eventTypeId directly inside the useMemo block, or use formMethods.watch("id") if reactive updates are needed before the next render.

Apply this diff to extract eventTypeId inside the useMemo:
-  const eventTypeId = formMethods.getValues("id");
-
   const EventTypeTabs = useMemo(() => {
+    const eventTypeId = formMethods.getValues("id");
     const navigation: VerticalTabItemProps[] = getNavigation({
Then remove eventTypeId from the dependencies array at line 160 (it's no longer needed since it's computed inside the memoized function).

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9ee06b4 and 7969ab6.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (1)

packages/platform/atoms/event-types/hooks/useTabsNavigations.tsx (5 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.tsx

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

Always use t() for text localization in frontend code; direct text embedding should trigger a warning

Files:

packages/platform/atoms/event-types/hooks/useTabsNavigations.tsx

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/review.mdc)

Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js .utc() in hot paths like loops

Files:

packages/platform/atoms/event-types/hooks/useTabsNavigations.tsx

**/*.{ts,tsx,js,jsx}

⚙️ CodeRabbit configuration file

Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.

Files:

packages/platform/atoms/event-types/hooks/useTabsNavigations.tsx

🔇 Additional comments (1)

packages/platform/atoms/event-types/hooks/useTabsNavigations.tsx (1)

148-167: Dependency additions look correct given the current implementation.

Adding eventTypeId (line 160), eventType.id (line 165), and formMethods (line 166) to the dependencies ensures the memoized navigation re-computes when these values change. However, note that if eventTypeId is moved inside the useMemo as suggested above, remove it from the dependencies array.

- Remove Cal.ai tab from event type navigation as functionality moved to workflows - Preserve backwards compatibility by keeping URL routing intact - Cal.ai banner already shows on workflows tab - Fix ESLint warnings by extracting complex expression and adding missing dependencies Co-Authored-By: [email protected] <[email protected]>

- Import and render CalAiBanner component in EventWorkflowsTab - Banner shows at top of workflows tab content for better visibility - Completes the task of moving Cal.ai functionality to workflows tab Co-Authored-By: [email protected] <[email protected]>

rodrigoehlers

LGTM, tab is gone but manual URL update still works.

github-actions · 2025-10-07T19:57:49Z

E2E results are ready!

Workflow #82233.3 latest results

pull-request-size bot added the size/S label Sep 17, 2025

keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Sep 17, 2025

pull-request-size bot added size/M and removed size/S labels Sep 17, 2025

vercel bot deployed to Preview – dev September 17, 2025 12:05 View deployment

github-actions bot added the Stale label Oct 2, 2025

PeerRich marked this pull request as ready for review October 7, 2025 10:42

PeerRich requested review from a team as code owners October 7, 2025 10:42

graphite-app bot requested a review from a team October 7, 2025 10:42

dosubot bot added ai area: AI, cal.ai ✨ feature New feature or request labels Oct 7, 2025

coderabbitai bot reviewed Oct 7, 2025

View reviewed changes

pull-request-size bot added size/XXL size/S and removed size/M size/XXL labels Oct 7, 2025

PeerRich enabled auto-merge (squash) October 7, 2025 10:47

PeerRich removed the Stale label Oct 7, 2025

vercel bot deployed to Preview – dev October 7, 2025 12:40 View deployment

devin-ai-integration bot and others added 4 commits October 7, 2025 20:35

nit

2a60c44

Discard changes to yarn.lock

31372a0

rodrigoehlers force-pushed the devin/remove-cal-ai-tab-1758108209 branch from aabbab5 to 31372a0 Compare October 7, 2025 18:36

pull-request-size bot added size/M and removed size/S labels Oct 7, 2025

rodrigoehlers approved these changes Oct 7, 2025

View reviewed changes

vercel bot deployed to Preview – dev October 7, 2025 19:22 View deployment

keithwillcode approved these changes Oct 7, 2025

View reviewed changes

graphite-app bot added the ready-for-e2e label Oct 7, 2025

PeerRich merged commit 4d51873 into main Oct 7, 2025
125 of 132 checks passed

PeerRich deleted the devin/remove-cal-ai-tab-1758108209 branch October 7, 2025 20:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: remove Cal.ai tab from navigation while preserving URL access #23894

feat: remove Cal.ai tab from navigation while preserving URL access #23894

Uh oh!

PeerRich commented Sep 17, 2025 •

edited by devin-ai-integration bot

Loading

Uh oh!

devin-ai-integration bot commented Sep 17, 2025

Uh oh!

coderabbitai bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

vercel bot commented Sep 17, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

coderabbitai bot left a comment

Uh oh!

rodrigoehlers left a comment

Uh oh!

github-actions bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

feat: remove Cal.ai tab from navigation while preserving URL access #23894

feat: remove Cal.ai tab from navigation while preserving URL access #23894

Uh oh!

Conversation

PeerRich commented Sep 17, 2025 • edited by devin-ai-integration bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Key Changes

Banner Addition (EventWorkflowsTab.tsx)

Tab Removal (useTabsNavigations.tsx)

⚠️ Important Review Areas

How should this be tested?

Mandatory Tasks (DO NOT REMOVE)

Uh oh!

devin-ai-integration bot commented Sep 17, 2025

🤖 Devin AI Engineer

Uh oh!

coderabbitai bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Pre-merge checks and finishing touches

Uh oh!

vercel bot commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

rodrigoehlers left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E results are ready!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PeerRich commented Sep 17, 2025 •

edited by devin-ai-integration bot

Loading

Banner Addition (`EventWorkflowsTab.tsx`)

Tab Removal (`useTabsNavigations.tsx`)

coderabbitai bot commented Sep 17, 2025 •

edited

Loading

vercel bot commented Sep 17, 2025 •

edited

Loading

github-actions bot commented Oct 7, 2025 •

edited

Loading